[haiku-commits] Re: haiku: hrev45405 - build/jam
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 25 Mar 2013 01:45:50 +0100
On 03/25/2013 01:32 AM, Axel Dörfler wrote:
On 03/24/2013 04:28 PM, anevilyak@xxxxxxxxx wrote:
+# disable array bounds warnings on gcc 4.6 or newer since they trigger
+# too many false positives. Coverity does a better job of this kind
of analysis
+# anyways.
+if $(HAIKU_GCC_VERSION[1]) >= 4 {
+ if $(HAIKU_GCC_VERSION[2] >= 6) {
+ HAIKU_GCC_BASE_FLAGS += -Wno-array-bounds ;
That check should read something like this (dunno if Jam supports that,
though):
> +if $(HAIKU_GCC_VERSION[1]) = 4 && $(HAIKU_GCC_VERSION[2]) >= 6 ||
$(HAIKU_GCC_VERSION[1]) > 4 {
We only support building a certain Haiku revision with the matching gcc
2 and 4 versions. I don't really see the point in making things more
complicated.
In any case, the second check looks like a typo; the closing parenthesis
should come before the >= operator.
Indeed. Pretty annoying that jam doesn't error out in such a case.
CU, Ingo
Other related posts:
