[haiku-commits] Re: haiku: hrev45229 - src/kits/tracker
- From: Landon Fuller <landonf@xxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 3 Feb 2013 10:50:42 -0500
I think it'd be really nice to pluralize this based the actual number of items,
or to specifically list the items that can't be deleted. If the code is never
executed, then this is somewhat academic :)
On Feb 2, 2013, at 12:25 PM, mattmadia@xxxxxxxxx wrote:
> hrev45229 adds 1 changeset to branch 'master'
> old head: ac78048b58edae127cf7d0aa1413b64eaf642e97
> new head: 0288eb774216e0e2925dcb31e2c1ddc6e190f35e
> overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=0288eb7+%5Eac78048
>
> ----------------------------------------------------------------------------
>
> 0288eb7: Reword an alert prompt to be less detailed, but more correct.
>
> Resolves #6654. To note, AFAICT, this code block should never be executed.
> However, I did feel comfortable removing it, in case the location of Trash
> is relocated in the future.
>
> [ Matt Madia <mattmadia@xxxxxxxxx> ]
>
> ----------------------------------------------------------------------------
>
> Revision: hrev45229
> Commit: 0288eb774216e0e2925dcb31e2c1ddc6e190f35e
> URL: http://cgit.haiku-os.org/haiku/commit/?id=0288eb7
> Author: Matt Madia <mattmadia@xxxxxxxxx>
> Date: Sat Feb 2 17:15:30 2013 UTC
>
> Ticket: https://dev.haiku-os.org/ticket/6654
>
> ----------------------------------------------------------------------------
>
> 1 file changed, 2 insertions(+), 2 deletions(-)
> src/kits/tracker/FSUtils.cpp | 4 ++--
>
> ----------------------------------------------------------------------------
>
> diff --git a/src/kits/tracker/FSUtils.cpp b/src/kits/tracker/FSUtils.cpp
> index b582118..f001b29 100644
> --- a/src/kits/tracker/FSUtils.cpp
> +++ b/src/kits/tracker/FSUtils.cpp
> @@ -1915,8 +1915,8 @@ MoveEntryToTrash(BEntry* entry, BPoint* loc, Undo &undo)
>
> if (dir == trash_dir || dir.Contains(&trashEntry)) {
> BAlert* alert = new BAlert("",
> - B_TRANSLATE("You cannot put the Trash, home or
> Desktop "
> - "directory into the trash."),
> + B_TRANSLATE("You cannot put the selected
> item(s) "
> + "into the trash."),
> B_TRANSLATE("OK"),
> 0, 0, B_WIDTH_AS_USUAL, B_WARNING_ALERT);
> alert->SetFlags(alert->Flags() | B_CLOSE_ON_ESCAPE);
>
>
Other related posts:
