hrev45042 adds 1 changeset to branch 'master' old head: 7ff146fdc0b3acf460b93d4b606d2be9b301e7a5 new head: cd03d7c12004ef95ed8e942b8affc8cced7be1c6 overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=cd03d7c+%5E7ff146f ---------------------------------------------------------------------------- cd03d7c: Remove locking from TrackerSettingsWindow::QuitRequested() Like Deskbar it isn't needed here either since the window is already locked. The return value seems to be totally ignored, so, just leave as is. [ John Scipione <jscipione@xxxxxxxxx> ] ---------------------------------------------------------------------------- Revision: hrev45042 Commit: cd03d7c12004ef95ed8e942b8affc8cced7be1c6 URL: http://cgit.haiku-os.org/haiku/commit/?id=cd03d7c Author: John Scipione <jscipione@xxxxxxxxx> Date: Fri Dec 21 21:42:37 2012 UTC ---------------------------------------------------------------------------- 1 file changed, 1 insertion(+), 10 deletions(-) src/kits/tracker/TrackerSettingsWindow.cpp | 11 +---------- ---------------------------------------------------------------------------- diff --git a/src/kits/tracker/TrackerSettingsWindow.cpp b/src/kits/tracker/TrackerSettingsWindow.cpp index 552f073..4be73c1 100644 --- a/src/kits/tracker/TrackerSettingsWindow.cpp +++ b/src/kits/tracker/TrackerSettingsWindow.cpp @@ -135,19 +135,10 @@ TrackerSettingsWindow::TrackerSettingsWindow() bool TrackerSettingsWindow::QuitRequested() { - bool isHidden = false; - - if (Lock()) { - isHidden = IsHidden(); - Unlock(); - } else - return true; - - if (isHidden) + if (IsHidden()) return true; Hide(); - return false; }