[haiku-commits] Re: haiku: hrev43582 - src/add-ons/kernel/drivers/network/wlan/marvell88w8363/dev/mwl

  • From: Siarzhuk Zharski <zharik@xxxxxx>
  • To: <haiku-commits@xxxxxxxxxxxxx>
  • Date: Fri, 30 Dec 2011 10:03:43 +0200

On Fri, 30 Dec 2011 05:30:44 +0100 (CET), stpere@xxxxxxxxx wrote:
Author:      Philippe Saint-Pierre <stpere@xxxxxxxxx>

[...]

-       sp->public.data[0] = a1;
-       sp->public.data[1] = a2;
-       IEEE80211_ADDR_COPY(sp->macaddr, Macaddr);
-       sp->tid = Tid;
-       sp->paraminfo = ParamInfo;
-       sp->setup = 0;
-       sp->ba_policy = ba_policy;
-       MWL_HAL_UNLOCK(mh);
-       return sp != NULL ? &sp->public : NULL;
+       if (sp != NULL) {
+               sp->public.data[0] = a1;
+               sp->public.data[1] = a2;
+               IEEE80211_ADDR_COPY(sp->macaddr, Macaddr);

Dealing with the third-party sources, it is a good idea to separate your changes in the

#ifdef __HAIKU__

sections. It will be usefull hint for your followers during updating corresponding sources with more actual version from FreeBSD.

--
Kind Regards,
   S.Zharski

Other related posts: