[haiku-commits] Re: haiku: hrev43389 - src/apps/terminal

  • From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 04 Dec 2011 02:38:38 +0100

zharik@xxxxxx wrote:
> hrev43389 adds 1 changeset to branch 'master'
> old head: 7418dbd90806ceb5702ad20c73b143928b75e212
> new head: d79b659e2686c66740e0609427b608efbf889238
> ----------------------------------------------------------------------------
> d79b659: Terminal:Fix printing and windows settings path.
>  * Fixes #7986 - behavior of Print command fixed to be consistent
>  with other application, like StyledEdit. This change
>  display the print job settings dialog instead of "Printing
>  was cancelled" alert;
>  * Fixes #6998 - the path to storing windows settings changed from
>  ~/config/settings/Terminal_windows to ~/c/s/Terminal/Windows;
>  This patch was created during GCI 2011 by doctorkohaku.
>  Thanks for the contribution!
> Author: Siarzhuk Zharski <zharik@xxxxxx>

Now, that we use git, we should get the attribution right. I haven't done this 
myself, but it seems "git am" is the command to be used to apply patches ("git 
format-patch" to create them in the first place). I think it would a good idea 
to use the --signoff option, so it is recorded who accepted the patch.

CU, Ingo

Other related posts: