[haiku-commits] Change in haiku[master]: system/u-boot: Some 64-bit cleanups to our u-boot code

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 28 Jan 2020 14:56:22 +0000

From Alex von Gluck IV <kallisti5@xxxxxxxxxxx>:

Alex von Gluck IV has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2171 ;)


Change subject: system/u-boot: Some 64-bit cleanups to our u-boot code
......................................................................

system/u-boot: Some 64-bit cleanups to our u-boot code

Change-Id: I70c50b36cd56263dcb37faeffc4037dea4af88c0
---
M src/system/boot/platform/u-boot/start.cpp
1 file changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/71/2171/1

diff --git a/src/system/boot/platform/u-boot/start.cpp 
b/src/system/boot/platform/u-boot/start.cpp
index 89ad39c..d05e1a3 100644
--- a/src/system/boot/platform/u-boot/start.cpp
+++ b/src/system/boot/platform/u-boot/start.cpp
@@ -123,13 +123,13 @@
        mmu_init_for_kernel();
 //     smp_boot_other_cpus();

-       dprintf("ncpus %lx\n", gKernelArgs.num_cpus);
-       dprintf("kernel entry at %lx\n", kernelEntry);
+       dprintf("ncpus %" B_PRId32 "\n", gKernelArgs.num_cpus);
+       dprintf("kernel entry at 0x%" B_PRIxADDR "\n", kernelEntry);

        status_t error = arch_start_kernel(&gKernelArgs, kernelEntry,
                stackTop);

-       panic("kernel returned %lx!\n", error);
+       panic("kernel returned 0x%" B_PRIx32 "!\n", error);
 }


@@ -271,7 +271,7 @@
                int i;
                dprintf("argc = %d\n", argc);
                for (i = 0; i < argc; i++)
-                       dprintf("argv[%d] @%lx = '%s'\n", i, (uint32)argv[i], 
argv[i]);
+                       dprintf("argv[%d] @%" B_PRIxADDR " = '%s'\n", i, 
(addr_t)argv[i], argv[i]);
                dprintf("os: %d\n", (int)gUBootOS);
                dprintf("gd @ %p\n", gUBootGlobalData);
                if (gUBootGlobalData) {
@@ -335,8 +335,8 @@
                }
                dprintf("args.arguments_count = %" B_PRId32 "\n", 
args.arguments_count);
                for (int i = 0; i < args.arguments_count; i++)
-                       dprintf("args.arguments[%d] @%lx = '%s'\n", i,
-                               (uint32)args.arguments[i], args.arguments[i]);
+                       dprintf("args.arguments[%d] @%" B_PRIxADDR " = '%s'\n", 
i,
+                               (addr_t)args.arguments[i], args.arguments[i]);
        }

        // wait a bit to give the user the opportunity to press a key

--
To view, visit https://review.haiku-os.org/c/haiku/+/2171
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I70c50b36cd56263dcb37faeffc4037dea4af88c0
Gerrit-Change-Number: 2171
Gerrit-PatchSet: 1
Gerrit-Owner: Alex von Gluck IV <kallisti5@xxxxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: system/u-boot: Some 64-bit cleanups to our u-boot code - Gerrit