[haiku-commits] Change in haiku[master]: runtime_loader: Fix PVS V595

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 5 Feb 2020 10:07:18 +0000

From Murai Takashi <tmurai01@xxxxxxxxx>:

Murai Takashi has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2202 ;)


Change subject: runtime_loader: Fix PVS V595
......................................................................

runtime_loader: Fix PVS V595

Add NULL check for fValuesResolved, since malloc() might
return NULL.

Change-Id: I3849ddfcffd7712fec3d90546244c6b17e4d0f77
---
M src/system/runtime_loader/elf_symbol_lookup.h
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/02/2202/1

diff --git a/src/system/runtime_loader/elf_symbol_lookup.h 
b/src/system/runtime_loader/elf_symbol_lookup.h
index f3f031b..dbe5251 100644
--- a/src/system/runtime_loader/elf_symbol_lookup.h
+++ b/src/system/runtime_loader/elf_symbol_lookup.h
@@ -69,7 +69,8 @@

                        size_t elementCount = (fTableSize + 31) / 32;
                        fValuesResolved = (uint32*)malloc(4 * elementCount);
-                       memset(fValuesResolved, 0, 4 * elementCount);
+                       if (fValuesResolved != NULL)
+                               memset(fValuesResolved, 0, 4 * elementCount);

                        if (fValues == NULL || fDSOs == NULL || fValuesResolved 
== NULL) {
                                free(fValuesResolved);

--
To view, visit https://review.haiku-os.org/c/haiku/+/2202
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I3849ddfcffd7712fec3d90546244c6b17e4d0f77
Gerrit-Change-Number: 2202
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: runtime_loader: Fix PVS V595 - Gerrit