[haiku-commits] Change in haiku[master]: kernel: fix trace build for fd.cpp and fifo.cpp

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 20 Jun 2022 15:13:38 +0000

From Jérôme Duval <jerome.duval@xxxxxxxxx>:

Jérôme Duval has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/5391 ;)


Change subject: kernel: fix trace build for fd.cpp and fifo.cpp
......................................................................

kernel: fix trace build for fd.cpp and fifo.cpp
---
M src/system/kernel/fs/fd.cpp
M src/system/kernel/fs/fifo.cpp
2 files changed, 9 insertions(+), 9 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/91/5391/1

diff --git a/src/system/kernel/fs/fd.cpp b/src/system/kernel/fs/fd.cpp
index 4389bfe..6fa5483 100644
--- a/src/system/kernel/fs/fd.cpp
+++ b/src/system/kernel/fs/fd.cpp
@@ -209,7 +209,7 @@

        TFD(PutFD(descriptor));

-       TRACE(("put_fd(descriptor = %p [ref = %ld, cookie = %p])\n",
+       TRACE(("put_fd(descriptor = %p [ref = %" B_PRId32 ", cookie = %p])\n",
                descriptor, descriptor->ref_count, descriptor->cookie));

        // free the descriptor if we don't need it anymore
@@ -567,7 +567,7 @@
 status_t
 select_fd(int32 fd, struct select_info* info, bool kernel)
 {
-       TRACE(("select_fd(fd = %ld, info = %p (%p), 0x%x)\n", fd, info,
+       TRACE(("select_fd(fd = %" B_PRId32 ", info = %p (%p), 0x%x)\n", fd, 
info,
                info->sync, info->selected_events));

        FDGetter fdGetter;
@@ -646,7 +646,7 @@
 status_t
 deselect_fd(int32 fd, struct select_info* info, bool kernel)
 {
-       TRACE(("deselect_fd(fd = %ld, info = %p (%p), 0x%x)\n", fd, info,
+       TRACE(("deselect_fd(fd = %" B_PRId32 ", info = %p (%p), 0x%x)\n", fd, 
info,
                info->sync, info->selected_events));

        FDGetter fdGetter;
@@ -959,7 +959,7 @@
        uint32 maxCount)
 {
        TRACE(("user_read_dir(fd = %d, userBuffer = %p, bufferSize = %ld, count 
= "
-               "%lu)\n", fd, userBuffer, bufferSize, maxCount));
+               "%" B_PRIu32 ")\n", fd, userBuffer, bufferSize, maxCount));

        if (maxCount == 0)
                return 0;
@@ -1286,7 +1286,7 @@
        ssize_t retval;

        TRACE(("sys_read_dir(fd = %d, buffer = %p, bufferSize = %ld, count = "
-               "%lu)\n",fd, buffer, bufferSize, maxCount));
+               "%" B_PRIu32 ")\n",fd, buffer, bufferSize, maxCount));

        struct io_context* ioContext = get_current_io_context(true);
        descriptor = get_fd(ioContext, fd);
diff --git a/src/system/kernel/fs/fifo.cpp b/src/system/kernel/fs/fifo.cpp
index 2989889..a49b3f2 100644
--- a/src/system/kernel/fs/fifo.cpp
+++ b/src/system/kernel/fs/fifo.cpp
@@ -656,11 +656,11 @@
 void
 Inode::Close(file_cookie* cookie)
 {
-       TRACE("Inode %p::Close(openMode = %d)\n", this, openMode);

        MutexLocker locker(RequestLock());

        int openMode = cookie->open_mode;
+       TRACE("Inode %p::Close(openMode = %" B_PRId32 ")\n", this, openMode);

        // Notify all currently reading file descriptors
        ReadRequestList::Iterator iterator = fReadRequests.GetIterator();
@@ -1065,8 +1065,8 @@
        file_cookie* cookie = (file_cookie*)_cookie;
        Inode* inode = (Inode*)_node->private_node;

-       TRACE("fifo_ioctl: vnode %p, cookie %p, op %ld, buf %p, len %ld\n",
-               _vnode, _cookie, op, buffer, length);
+       TRACE("fifo_ioctl: vnode %p, cookie %p, op %" B_PRId32 ", buf %p, len 
%ld\n",
+               _node, _cookie, op, buffer, length);

        switch (op) {
                case FIONBIO:
@@ -1129,7 +1129,7 @@
        Inode* inode = (Inode*)_node->private_node;
        file_cookie* cookie = (file_cookie*)_cookie;

-       TRACE("fifo_set_flags(vnode = %p, flags = %x)\n", _vnode, flags);
+       TRACE("fifo_set_flags(vnode = %p, flags = %x)\n", _node, flags);

        MutexLocker locker(inode->RequestLock());
        cookie->open_mode = (cookie->open_mode & ~(O_APPEND | O_NONBLOCK)) | 
flags;

--
To view, visit https://review.haiku-os.org/c/haiku/+/5391
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I12b2e85926ae63eaba5c077343cdaa2362cf8af1
Gerrit-Change-Number: 5391
Gerrit-PatchSet: 1
Gerrit-Owner: Jérôme Duval <jerome.duval@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: kernel: fix trace build for fd.cpp and fifo.cpp - Gerrit