[haiku-commits] Change in haiku[master]: bin/media_client: Fix memory leak

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 8 Dec 2020 21:05:16 +0000

From Murai Takashi <tmurai01@xxxxxxxxx>:

Murai Takashi has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3480 ;)


Change subject: bin/media_client: Fix memory leak
......................................................................

bin/media_client: Fix memory leak

Fix leak of memory allocated to 'app'.
Pointed out by Clang Static Analyzer.

Change-Id: I59d39b76a18893bd284db1d75e40620bb1aee9e2
---
M src/bin/media_client/media_client.cpp
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/80/3480/1

diff --git a/src/bin/media_client/media_client.cpp 
b/src/bin/media_client/media_client.cpp
index 8a4900a..2891194 100644
--- a/src/bin/media_client/media_client.cpp
+++ b/src/bin/media_client/media_client.cpp
@@ -27,8 +27,7 @@
                return 0;
        }

-       BApplication* app = new BApplication(
-               "application/x-vnd.Haiku-media_client");
+       BApplication app("application/x-vnd.Haiku-media_client");

        int ret = 0;
        if (strcmp(argv[1], "play") == 0) {

--
To view, visit https://review.haiku-os.org/c/haiku/+/3480
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I59d39b76a18893bd284db1d75e40620bb1aee9e2
Gerrit-Change-Number: 3480
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: bin/media_client: Fix memory leak - Gerrit