[haiku-commits] Change in haiku[master]: app_server: fix stack overflow crash if too many windows are tiled

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 11 May 2020 07:59:00 +0000

From X512 <danger_mail@xxxxxxx>:

X512 has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2680 ;)


Change subject: app_server: fix stack overflow crash if too many windows are 
tiled
......................................................................

app_server: fix stack overflow crash if too many windows are tiled

Fixes #15796.

Change-Id: I24c29215116e6bad37f0a56e141d6fc26bbe4fb2
---
M src/servers/app/decorator/TabDecorator.cpp
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/80/2680/1

diff --git a/src/servers/app/decorator/TabDecorator.cpp 
b/src/servers/app/decorator/TabDecorator.cpp
index 2d6235a..99d61d7 100644
--- a/src/servers/app/decorator/TabDecorator.cpp
+++ b/src/servers/app/decorator/TabDecorator.cpp
@@ -439,6 +439,8 @@
        }

        float minus = ceilf(std::min(maxTabSize - secMaxTabSize, delta));
+       if (minus < 1.0)
+               return;
        delta -= minus;
        minus /= nTabsWithMaxSize;


--
To view, visit https://review.haiku-os.org/c/haiku/+/2680
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I24c29215116e6bad37f0a56e141d6fc26bbe4fb2
Gerrit-Change-Number: 2680
Gerrit-PatchSet: 1
Gerrit-Owner: X512 <danger_mail@xxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: app_server: fix stack overflow crash if too many windows are tiled - Gerrit