[haiku-commits] Change in haiku[master]: Tracker: Use ObjectDeleter instead of the deprecated std::auto_ptr.

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 8 Mar 2020 02:52:11 +0000

From waddlesplash <waddlesplash@xxxxxxxxx>:

waddlesplash has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2321 ;)


Change subject: Tracker: Use ObjectDeleter instead of the deprecated 
std::auto_ptr.
......................................................................

Tracker: Use ObjectDeleter instead of the deprecated std::auto_ptr.
---
M src/kits/tracker/ContainerWindow.cpp
1 file changed, 3 insertions(+), 5 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/21/2321/1

diff --git a/src/kits/tracker/ContainerWindow.cpp 
b/src/kits/tracker/ContainerWindow.cpp
index 65d61b5..d4a4b7c 100644
--- a/src/kits/tracker/ContainerWindow.cpp
+++ b/src/kits/tracker/ContainerWindow.cpp
@@ -65,11 +65,9 @@
 #include <strings.h>
 #include <stdlib.h>

-#include <algorithm>
-#include <memory>
-
 #include "Attributes.h"
 #include "AttributeStream.h"
+#include "AutoDeleter.h"
 #include "AutoLock.h"
 #include "BackgroundImage.h"
 #include "Commands.h"
@@ -298,7 +296,7 @@
 static int32
 AddOnThread(BMessage* refsMessage, entry_ref addonRef, entry_ref directoryRef)
 {
-       std::auto_ptr<BMessage> refsMessagePtr(refsMessage);
+       ObjectDeleter<BMessage> _(refsMessage);

        BEntry entry(&addonRef);
        BPath path;
@@ -315,7 +313,7 @@

                        if (result >= 0) {
                                // call add-on code
-                               (*processRefs)(directoryRef, 
refsMessagePtr.get(), NULL);
+                               (*processRefs)(directoryRef, refsMessage, NULL);

                                unload_add_on(addonImage);
                                return B_OK;

--
To view, visit https://review.haiku-os.org/c/haiku/+/2321
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I5d358076065fefa39df923e4554599b716d9883b
Gerrit-Change-Number: 2321
Gerrit-PatchSet: 1
Gerrit-Owner: waddlesplash <waddlesplash@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Tracker: Use ObjectDeleter instead of the deprecated std::auto_ptr. - Gerrit