[haiku-commits] Change in haiku[master]: Tracker: Improve pose loading speed, add comments

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 20 Aug 2019 22:09:05 +0000

From Ryan Leavengood <leavengood@xxxxxxxxx>:

Ryan Leavengood has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/1726 ;)


Change subject: Tracker: Improve pose loading speed, add comments
......................................................................

Tracker: Improve pose loading speed, add comments

If a new pose is going to be placed below the current view bounds, we
definitely do not need to do any drawing. If it is above or inside the view
bounds we do this special drawing method.

Overall this method of doing updates is complicated and hard to adjust without
introducing drawing artifacts. As noted in the TODO, this should be rethought
from scratch.

But for now in one case of over 8000 files in a single directory this improved
the loading speed from about 8 or 9 seconds to 1. Queries results also load
much faster. I am testing in a VM with a single CPU on a host with an SSD, so
others may see better performance with more CPUs, or less with a spinning hard
drive.

But at least now the drawing won't be the bottleneck.

Should finally fully fix #3011, or at least good enough for close.
---
M src/kits/tracker/PoseView.cpp
1 file changed, 75 insertions(+), 52 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/26/1726/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/1726
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I3806ffa7674e404c9db24edb33d6ab4eb2d825f7
Gerrit-Change-Number: 1726
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Leavengood <leavengood@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Tracker: Improve pose loading speed, add comments - Gerrit