[haiku-commits] Change in haiku[master]: TextSearch: change Select all shortcut

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 19 Jul 2020 16:32:19 +0000

From Kacper Kasper <kacperkasper@xxxxxxxxx>:

Kacper Kasper has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3043 ;)


Change subject: TextSearch: change Select all shortcut
......................................................................

TextSearch: change Select all shortcut

Anecdotal: whenever I hit Cmd+A with text field focused I want to
quickly select search phrase, not the results. In fact I never found
myself in a situation where the latter is the desired outcome.
---
M src/apps/text_search/GrepWindow.cpp
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/43/3043/1

diff --git a/src/apps/text_search/GrepWindow.cpp 
b/src/apps/text_search/GrepWindow.cpp
index 46f97a4..faa0ed2 100644
--- a/src/apps/text_search/GrepWindow.cpp
+++ b/src/apps/text_search/GrepWindow.cpp
@@ -427,7 +427,8 @@
                B_TRANSLATE("Search"), new BMessage(MSG_START_CANCEL), 'S');

        fSelectAll = new BMenuItem(
-               B_TRANSLATE("Select all"), new BMessage(MSG_SELECT_ALL), 'A');
+               B_TRANSLATE("Select all"), new BMessage(MSG_SELECT_ALL),
+               'A', B_SHIFT_KEY);

        fTrimSelection = new BMenuItem(
                B_TRANSLATE("Trim to selection"), new 
BMessage(MSG_TRIM_SELECTION), 'T');

--
To view, visit https://review.haiku-os.org/c/haiku/+/3043
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ib5edcee8e7366485181cb2030ecfa989619cd600
Gerrit-Change-Number: 3043
Gerrit-PatchSet: 1
Gerrit-Owner: Kacper Kasper <kacperkasper@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: TextSearch: change Select all shortcut - Gerrit