[haiku-commits] Change in haiku[master]: Terminal: Fix -Wtautological-constant-out-of-range-compare

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 22 Oct 2018 11:36:07 +0000

From Murai Takashi <tmurai01@xxxxxxxxx>:

Murai Takashi has uploaded this change for review. ( 
https://review.haiku-os.org/637


Change subject: Terminal: Fix -Wtautological-constant-out-of-range-compare
......................................................................

Terminal: Fix -Wtautological-constant-out-of-range-compare

Since index is 'uint8', 'index < kTermColorCount' is always true.
Pointed out by clang.

Change-Id: I49e45cbd8a55223177fd2d6a64a0e37cf6341fc7
---
M src/apps/terminal/TermView.cpp
M src/apps/terminal/TerminalBuffer.cpp
2 files changed, 3 insertions(+), 5 deletions(-)



  git pull ssh://git.haiku-os.org/haiku refs/changes/37/637/1
--
To view, visit https://review.haiku-os.org/637
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49e45cbd8a55223177fd2d6a64a0e37cf6341fc7
Gerrit-Change-Number: 637
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Terminal: Fix -Wtautological-constant-out-of-range-compare - Gerrit