[haiku-commits] Change in haiku[master]: TabDecorator: fix invalidation when removing a tab.

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 8 May 2020 19:36:02 +0000

From Adrien Destugues <pulkomandy@xxxxxxxxx>:

Adrien Destugues has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2609 ;)


Change subject: TabDecorator: fix invalidation when removing a tab.
......................................................................

TabDecorator: fix invalidation when removing a tab.

Fixes #12085.
---
M src/servers/app/decorator/TabDecorator.cpp
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/09/2609/1

diff --git a/src/servers/app/decorator/TabDecorator.cpp 
b/src/servers/app/decorator/TabDecorator.cpp
index fe64fc9..2d6235a 100644
--- a/src/servers/app/decorator/TabDecorator.cpp
+++ b/src/servers/app/decorator/TabDecorator.cpp
@@ -793,10 +793,11 @@
 bool
 TabDecorator::_RemoveTab(int32 index, BRegion* updateRegion)
 {
-       BRect oldTitle = fTitleBarRect;
+       BRect oldRect = TabRect(index) | TabRect(CountTabs() - 1);
+               // Get a rect of all the tabs to the right - they will all be 
moved
        _DoLayout();
        if (updateRegion != NULL) {
-               updateRegion->Include(oldTitle);
+               updateRegion->Include(oldRect);
                updateRegion->Include(fTitleBarRect);
        }
        return true;

--
To view, visit https://review.haiku-os.org/c/haiku/+/2609
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I346e39ba4dc6befe97f33f8ff409a6ac84ae8585
Gerrit-Change-Number: 2609
Gerrit-PatchSet: 1
Gerrit-Owner: Adrien Destugues <pulkomandy@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: TabDecorator: fix invalidation when removing a tab. - Gerrit