[haiku-commits] Change in haiku[master]: StyledEdit: Add comment explaining MakeFocus() loc

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 30 Jun 2022 03:17:42 +0000

From John Scipione <jscipione@xxxxxxxxx>:

John Scipione has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/5422 ;)


Change subject: StyledEdit: Add comment explaining MakeFocus() loc
......................................................................

StyledEdit: Add comment explaining MakeFocus() loc

... to explain hrev562209 by Jim906 which fixes #17733
StyledEdit: give initial focus to the TextView

No functional change
---
M src/apps/stylededit/StyledEditWindow.cpp
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/22/5422/1

diff --git a/src/apps/stylededit/StyledEditWindow.cpp 
b/src/apps/stylededit/StyledEditWindow.cpp
index cb8f3f8..f5ab506 100644
--- a/src/apps/stylededit/StyledEditWindow.cpp
+++ b/src/apps/stylededit/StyledEditWindow.cpp
@@ -1366,8 +1366,9 @@
        .End();

        SetKeyMenuBar(mainMenu);
-       fTextView->MakeFocus(true);

+       // must focus text view after window layout is built
+       fTextView->MakeFocus(true);
 }
 


--
To view, visit https://review.haiku-os.org/c/haiku/+/5422
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Id428290d8d3530e5ef9213489625c1968984d323
Gerrit-Change-Number: 5422
Gerrit-PatchSet: 1
Gerrit-Owner: John Scipione <jscipione@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: StyledEdit: Add comment explaining MakeFocus() loc - Gerrit