[haiku-commits] Change in haiku[master]: PathTest: Fix tests for BPath

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 15 Jan 2020 08:33:41 +0000

From Kyle Ambroff-Kao <kyle@xxxxxxxxxxxxxx>:

Kyle Ambroff-Kao has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2115 ;)


Change subject: PathTest: Fix tests for BPath
......................................................................

PathTest: Fix tests for BPath

* BPath::Flatten() on an empty path returns B_OK in BeOS R5, just
  writing an empty entry_ref to the povided buffer. The Haiku
  implementation has some additional validation that causes B_NO_INIT
  to be returned instead.
* Fix estimation of expected size when testing the return value of
  BPath::FlattenedSize().
* Clean up warning by removing unecessary forward-declaration of
  CppUnit::Test.
---
M src/tests/kits/storage/PathTest.cpp
M src/tests/kits/storage/PathTest.h
2 files changed, 3 insertions(+), 5 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/15/2115/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/2115
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I88880cbb298bdcb594c9c8fef48314165c49e9e5
Gerrit-Change-Number: 2115
Gerrit-PatchSet: 1
Gerrit-Owner: Kyle Ambroff-Kao <kyle@xxxxxxxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: PathTest: Fix tests for BPath - Gerrit