[haiku-commits] Change in haiku[master]: Menu: Fix dead store

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 7 Dec 2020 11:09:54 +0000

From Murai Takashi <tmurai01@xxxxxxxxx>:

Murai Takashi has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3472 ;)


Change subject: Menu: Fix dead store
......................................................................

Menu: Fix dead store

Fix value stored to 'flags' is never read.
Pointed out by Clang Static Analyzer.

Change-Id: Ia154fbdd4dd5fb10716cf9079625ca65e2f58122
---
M src/kits/interface/Menu.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/72/3472/1

diff --git a/src/kits/interface/Menu.cpp b/src/kits/interface/Menu.cpp
index f628951..72c0946 100644
--- a/src/kits/interface/Menu.cpp
+++ b/src/kits/interface/Menu.cpp
@@ -1426,7 +1426,7 @@
                borders |= BControlLook::B_TOP_BORDER
                        | BControlLook::B_BOTTOM_BORDER;
        }
-       be_control_look->DrawMenuBackground(this, rect, updateRect, base, 0,
+       be_control_look->DrawMenuBackground(this, rect, updateRect, base, flags,
                borders);
 }


--
To view, visit https://review.haiku-os.org/c/haiku/+/3472
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ia154fbdd4dd5fb10716cf9079625ca65e2f58122
Gerrit-Change-Number: 3472
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Menu: Fix dead store - Gerrit