[haiku-commits] Change in haiku[master]: Keymap: remove iterator change inside for loop, no functional change

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 22 Mar 2020 02:54:29 +0000

From X512 <danger_mail@xxxxxxx>:

X512 has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2392 ;)


Change subject: Keymap: remove iterator change inside for loop, no functional 
change
......................................................................

Keymap: remove iterator change inside for loop, no functional change

Pointed by clang.

Change-Id: I3aaad5b1e03385358ccb729251fa31d35108f389
---
M src/kits/shared/Keymap.cpp
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/92/2392/1

diff --git a/src/kits/shared/Keymap.cpp b/src/kits/shared/Keymap.cpp
index 5c86f26..9a77e6f 100644
--- a/src/kits/shared/Keymap.cpp
+++ b/src/kits/shared/Keymap.cpp
@@ -420,7 +420,7 @@

        // if dead key, we search for our current offset char in the dead key
        // offset table string comparison is needed
-       for (int32 i = 0; i < 32; i++) {
+       for (int32 i = 0; i < 32; i += 2) {
                if (strncmp(&fChars[offset + 1], &fChars[deadKey[i] + 1], 
*numBytes)
                                == 0) {
                        *numBytes = fChars[deadKey[i + 1]];
@@ -441,7 +441,6 @@
                        }
                        return;
                }
-               i++;
        }

        // if not found we return the current char mapped

--
To view, visit https://review.haiku-os.org/c/haiku/+/2392
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I3aaad5b1e03385358ccb729251fa31d35108f389
Gerrit-Change-Number: 2392
Gerrit-PatchSet: 1
Gerrit-Owner: X512 <danger_mail@xxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Keymap: remove iterator change inside for loop, no functional change - Gerrit