[haiku-commits] Change in haiku[master]: HaikuDepot: remove unneeded .Get() calls

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 9 Dec 2020 21:20:55 +0000

From X512 <danger_mail@xxxxxxx>:

X512 has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3489 ;)


Change subject: HaikuDepot: remove unneeded .Get() calls
......................................................................

HaikuDepot: remove unneeded .Get() calls

Dereference operator is defined in BReference.

Change-Id: Iccba8ad4a29e354aa9cdbf2e1a5ddbc9687af677
---
M src/apps/haikudepot/textview/Bullet.cpp
M src/apps/haikudepot/textview/CharacterStyle.cpp
M src/apps/haikudepot/textview/ParagraphStyle.cpp
3 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/89/3489/1

diff --git a/src/apps/haikudepot/textview/Bullet.cpp 
b/src/apps/haikudepot/textview/Bullet.cpp
index 44cf894..a0924c8 100644
--- a/src/apps/haikudepot/textview/Bullet.cpp
+++ b/src/apps/haikudepot/textview/Bullet.cpp
@@ -51,7 +51,7 @@
                return true;

        if (fBulletData.IsSet() && other.fBulletData.IsSet())
-               return *fBulletData.Get() == *other.fBulletData.Get();
+               return *fBulletData == *other.fBulletData;

        return false;
 }
diff --git a/src/apps/haikudepot/textview/CharacterStyle.cpp 
b/src/apps/haikudepot/textview/CharacterStyle.cpp
index d944ffe..731318d 100644
--- a/src/apps/haikudepot/textview/CharacterStyle.cpp
+++ b/src/apps/haikudepot/textview/CharacterStyle.cpp
@@ -41,7 +41,7 @@
                return true;

        if (fStyleData.IsSet() && other.fStyleData.IsSet())
-               return *fStyleData.Get() == *other.fStyleData.Get();
+               return *fStyleData == *other.fStyleData;

        return false;
 }
diff --git a/src/apps/haikudepot/textview/ParagraphStyle.cpp 
b/src/apps/haikudepot/textview/ParagraphStyle.cpp
index fdad949..205546d 100644
--- a/src/apps/haikudepot/textview/ParagraphStyle.cpp
+++ b/src/apps/haikudepot/textview/ParagraphStyle.cpp
@@ -41,7 +41,7 @@
                return true;

        if (fStyleData.IsSet() && other.fStyleData.IsSet())
-               return *fStyleData.Get() == *other.fStyleData.Get();
+               return *fStyleData == *other.fStyleData;

        return false;
 }

--
To view, visit https://review.haiku-os.org/c/haiku/+/3489
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Iccba8ad4a29e354aa9cdbf2e1a5ddbc9687af677
Gerrit-Change-Number: 3489
Gerrit-PatchSet: 1
Gerrit-Owner: X512 <danger_mail@xxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: HaikuDepot: remove unneeded .Get() calls - Gerrit