[haiku-commits] Change in ...haiku[master]: HaikuDepot: Set package state when loading single package

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 8 Aug 2019 01:32:14 +0000

From Ryan Leavengood <leavengood@xxxxxxxxx>:

Ryan Leavengood has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/1694


Change subject: HaikuDepot: Set package state when loading single package
......................................................................

HaikuDepot: Set package state when loading single package

Without this, even installed packages still get an "Install" button.

Fixes #14821.

This was implemented by adding BPackageRoster::IsPackageActive. I decided to
have this take a location since GetActivePackages also did, but as noted in my
TODO comment, I think this is awkward.

It would also be nice to show the user they have a different version of a
particular package, but that would require some changes to IsPackageActive.
---
M headers/os/package/PackageRoster.h
M src/apps/haikudepot/ui/App.cpp
M src/kits/package/PackageRoster.cpp
3 files changed, 64 insertions(+), 0 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/94/1694/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/1694
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Iab0d35eb6b671a17711b0214b15164d296927e5a
Gerrit-Change-Number: 1694
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Leavengood <leavengood@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in ...haiku[master]: HaikuDepot: Set package state when loading single package - Gerrit