[haiku-commits] Change in haiku[master]: Deskbar: Improved UX

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 15 May 2020 08:34:54 +0000

From Panagiotis Vasilopoulos <hello@xxxxxxxxxxxxxxx>:

Panagiotis Vasilopoulos has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2701 ;)


Change subject: Deskbar: Improved UX
......................................................................

Deskbar: Improved UX

* Moved 'Power Off' on top of 'Restart system'.
* Made a few visual changes to the code that adhere better to the Haiku coding 
style.
* 'Suspend is now at the bottom of the shutdown submenu.
---
M src/apps/deskbar/DeskbarMenu.cpp
1 file changed, 13 insertions(+), 8 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/01/2701/1

diff --git a/src/apps/deskbar/DeskbarMenu.cpp b/src/apps/deskbar/DeskbarMenu.cpp
index 9dd5ba7..32ac848 100644
--- a/src/apps/deskbar/DeskbarMenu.cpp
+++ b/src/apps/deskbar/DeskbarMenu.cpp
@@ -294,11 +294,24 @@

        BMenu* shutdownMenu = new BMenu(B_TRANSLATE("Shutdown" 
B_UTF8_ELLIPSIS));

+       item = new BMenuItem(B_TRANSLATE("Power off"),
+               new BMessage(kShutdownSystem));
+       item->SetEnabled(!dragging);
+       shutdownMenu->AddItem(item);
+
+       BMessage* message = new BMessage(kShutdownSystem);
+       message->AddBool("confirm", true);
+       AddItem(new BMenuItem(shutdownMenu, message));
+
        item = new BMenuItem(B_TRANSLATE("Restart system"),
                new BMessage(kRebootSystem));
        item->SetEnabled(!dragging);
        shutdownMenu->AddItem(item);

+       BMessage* message = new BMessage(kRebootSystem);
+       message->AddBool("confirm", true);
+       AddItem(new BMenuItem(shutdownMenu, message));
+
        B_TRANSLATE_MARK_VOID("Suspend");

 #ifdef APM_SUPPORT
@@ -310,16 +323,8 @@
        }
 #endif

-       item = new BMenuItem(B_TRANSLATE("Power off"),
-               new BMessage(kShutdownSystem));
-       item->SetEnabled(!dragging);
-       shutdownMenu->AddItem(item);
        shutdownMenu->SetFont(be_plain_font);
-
        shutdownMenu->SetTargetForItems(be_app);
-       BMessage* message = new BMessage(kShutdownSystem);
-       message->AddBool("confirm", true);
-       AddItem(new BMenuItem(shutdownMenu, message));

        fAddState = kAddingRecents;


--
To view, visit https://review.haiku-os.org/c/haiku/+/2701
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I0d41e3e5656d5d9ea02e3cb072b6a6092c70c640
Gerrit-Change-Number: 2701
Gerrit-PatchSet: 1
Gerrit-Owner: Panagiotis Vasilopoulos <hello@xxxxxxxxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Deskbar: Improved UX - Gerrit