[haiku-commits] Change in haiku[master]: BWindow: Do not invoke BView handlers directly

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 17 Aug 2019 16:58:24 +0000

From Simon South <simon@xxxxxxxxxxxxxx>:

Simon South has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/1723 ;)


Change subject: BWindow: Do not invoke BView handlers directly
......................................................................

BWindow: Do not invoke BView handlers directly

When dispatching a message to a BView, pass the message on to the view's
MessageReceived() method rather than invoking one of its handlers (e.g.
KeyDown() or MouseDown()) directly.

This commit moves the existing handler-invoking logic from
BWindow::DispatchMessage() into BView::MessageReceived(), preserving the
existing functionality.

Fixes #15254.
---
M src/kits/interface/View.cpp
M src/kits/interface/Window.cpp
2 files changed, 122 insertions(+), 149 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/23/1723/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/1723
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I230c0781df13e54e08573a5a31d7550520c060d5
Gerrit-Change-Number: 1723
Gerrit-PatchSet: 1
Gerrit-Owner: Simon South <simon@xxxxxxxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: BWindow: Do not invoke BView handlers directly - Gerrit