[haiku-commits] Change in haiku[master]: BMenu: fix memory leak in scripting

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 4 Jul 2020 05:40:18 +0000

From X512 <danger_mail@xxxxxxx>:

X512 has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2987 ;)


Change subject: BMenu: fix memory leak in scripting
......................................................................

BMenu: fix memory leak in scripting

Change-Id: Ib1f43ee61f1e300e5a60bb398aa29b4a6ca8f7a5
---
M src/kits/interface/Menu.cpp
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/87/2987/1

diff --git a/src/kits/interface/Menu.cpp b/src/kits/interface/Menu.cpp
index 844340d..80e0a49 100644
--- a/src/kits/interface/Menu.cpp
+++ b/src/kits/interface/Menu.cpp
@@ -1676,6 +1676,7 @@
                                                        RemoveItem(index);
                                                else
                                                        RemoveItem(item);
+                                               delete item;
                                        }
                                }
                        }
@@ -1748,6 +1749,7 @@
                                                RemoveItem(index);
                                        else
                                                RemoveItem(item);
+                                       delete item;
                                }
                        }
                        break;

--
To view, visit https://review.haiku-os.org/c/haiku/+/2987
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ib1f43ee61f1e300e5a60bb398aa29b4a6ca8f7a5
Gerrit-Change-Number: 2987
Gerrit-PatchSet: 1
Gerrit-Owner: X512 <danger_mail@xxxxxxx>
Gerrit-MessageType: newchange

Other related posts: