[haiku-commits] Re: BRANCH xyzzy-github.x86_64 - in src/system: boot/platform/bios_ia32 kernel/arch/x86 kernel/arch/x86/32
- From: Alex Smith <alex@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 11 Jul 2012 21:28:40 +0100
On 11 July 2012 19:49, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> xyzzy-github.x86_64 wrote:
> [...]
> > diff --git a/headers/private/kernel/arch/x86/32/descriptors.h
> b/headers/private/kernel/arch/x86/32/descriptors.h
> > index c578acf..81fd842 100644
> > --- a/headers/private/kernel/arch/x86/32/descriptors.h
> > +++ b/headers/private/kernel/arch/x86/32/descriptors.h
> > @@ -50,6 +50,10 @@ typedef struct segment_descriptor {
> > uint32 base_31_24 : 8; // 24 - 31
> > } segment_descriptor;
> >
> > +typedef struct interrupt_descriptor {
> > + uint32 a, b;
> > +} interrupt_descriptor;
> > +
> > struct tss {
> > uint16 prev_task;
> > uint16 unused0;
> > diff --git a/src/system/boot/platform/bios_ia32/interrupts.cpp
> b/src/system/boot/platform/bios_ia32/interrupts.cpp
> > index c5efc58..2d5d0fa 100644
> > --- a/src/system/boot/platform/bios_ia32/interrupts.cpp
> > +++ b/src/system/boot/platform/bios_ia32/interrupts.cpp
> > @@ -83,11 +83,6 @@ struct interrupt_frame {
> > uint32 eflags;
> > };
> >
> > -struct interrupt_descriptor {
> > - uint32 a;
> > - uint32 b;
> > -};
>
> Please stick with the one line per member style.
Ah, that happened because I copied the desc_table structure definition
rather than that one which had both members on the same line, and renamed
it to interrupt_descriptor. I'll change it.
On 11 July 2012 20:09, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> On 11.07.2012 19:49, xyzzy-github.x86_64 wrote:
>
>> +typedef struct interrupt_descriptor {
>> + uint32 a, b;
>> +} interrupt_descriptor;
>>
>
> In addition to what Ingo wrote: what is the point of using a typedef?
> I guess there isn't any C code left that could make use of it.
>
Probably not, I was just matching what was already in the header. I'll
change all of it to remove the typedefs.
Thanks,
Alex
Other related posts:
