[haiku-commits] Re: BRANCH waddlesplash-github.libroot-sha256 [e6a3dfe38b01] src/system/libroot/posix/crypt src/kits/shared headers/private/libroot src headers/private/shared
- From: Rene Gollent <anevilyak@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 2 Oct 2017 07:56:36 -0400
On Mon, Oct 2, 2017 at 6:45 AM, waddlesplash-github.libroot-sha256
<community@xxxxxxxxxxxx> wrote:
e6a3dfe38b01: [INCOMPLETE] Move SHA256 class to libroot instead of linking
libshared into libroot.
I have a hunch that a lot of the really weird random crashes that just
started appearing might be caused due to the BControlLook ABI change.
Especially seeing as some of the crashes occur in static init/deinit.
Which is a really wild guess, to be sure, but nobody has anything else
to go on.
At any rate, linking libshared to libroot was a terrible idea in the first
place, so PulkoMandy and I discussed doing this and agreed it was the right
thing to do.
This explanation makes no real sense in any way. libshared is a static
library, not a DSO. As such, when linking it to libroot, only the
pieces libroot actually references (e.g. SHA256.o) are included in the
final libroot that's produced as a result, which is functionally no
different from what you're proposing to do (and hardly a "terrible
idea"). Furthermore, BControlLook lives in libbe, not libshared or
libroot, so I have no idea how you think the issues are in any way
conflated. If it's a result of ABI changes, then the implication is
that packages haven't properly been rebuilt against a newer Haiku with
the changes.
Rene
Other related posts:
