[haiku-commits] Re: BRANCH tqh-github.efi_pm [7ab42dc] src/system/boot/platform/efi

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 15 Dec 2013 22:31:28 +0100

Am 15/12/2013 01:00, schrieb tqh-github.efi_pm:
+++ b/src/system/boot/platform/efi/keyboard.cpp
@@ -0,0 +1,75 @@
+/*
+ * Copyright 2004-2011, Axel Dörfler, axeld@xxxxxxxxxxxxxxxx.

I'm pretty sure that I did not write that :-)
There is no need to copy my name because of some function prototypes.

+/*!    Note, checking for keys doesn't seem to work in graphics
+       mode, at least in Bochs.
+*/
+static uint16
+check_for_key(void)
+{
+       EFI_INPUT_KEY key;
+       return (kSystemTable->ConIn->ReadKeyStroke(kSystemTable->ConIn, &key) ==
+               EFI_NOT_READY) ? 0 : key.UnicodeChar;

It also doesn't look like the comment still applies. And the parenthesis are superfluous.

On another topic, I assume "ConIn" does not come from you, but some EFI library?
Bye,
   Axel.

Other related posts: