[haiku-commits] Re: BRANCH orangejua-github.app_server [551438b9be6b] in src: servers/app tests/servers/app/unit_tests servers/app/drawing/Painter
- From: Stephan Aßmus <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 31 Jul 2015 19:29:24 +0200
Hi Looncraz and Julian,
Am 31.07.2015 um 19:08 schrieb looncraz:
On 7/31/2015 11:48, Julian Harnath wrote:
Hey,
On 31.07.2015 17:32, looncraz wrote:
Is this just not implemented yet and I'm getting ahead of you, or is
this a bug?
It's implemented and should work fine. Could you share the source of
your test program so I can check what's going on there?
--
Julian
Okay, so I took a quick look and figured it out... I had a BBox over the
area I was drawing... /oops
That'll learn me to reuse old drawing tests...
Now to do some benchmarking and to see what usefulness this may have
(though your use of Picture and AlphaMask has given some different ideas
about the best way to implement in-window compositing...).
Basically, I have encountered the need for such a layering API in many
situations. And this implementation - recording the graphics calls on
the layer, then allocating and blending exactly the changed portion,
sounds very efficient to me. And it is targetting directly the need of
WebKit. I'm all for it! This doesn't prevent implementing other options
and strategies as alternatives, for when those alternatives make more
sense. But I am very happy about what Julian did, since it shows very
strong research into what exactly is going on with the performance
problems of Haiku-WebKit and how to best counter them. Plus all the
research that went into getting familiar with the app_server code. It's
not so straight forward given all the optimizations and many involved
classes, as you probably know all too well.
Well done, Julian!
Best regards,
-Stephan
Other related posts: