[haiku-commits] Re: BRANCH midar-github.master - src/apps/terminal

  • From: Jonathan Schleifer <js-haiku-commits@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 18 Nov 2012 10:26:19 +0100

Am 17.11.2012 um 21:01 schrieb François Revol:

>> 39b2097: Terminal: Use brighter colors instead of bold.
> Why some will like it, I'm sure others will step in...
> maybe make it configurable?

Actually, the old version variant (render it bold) was just broken: It just 
rendered the letter again with an x offset of 1. Just look at a bold m: It's 
not readable as an m anymore, but as a black box.

I talked about this with PulkoMandy and I asked him whether I should make this 
an option. He said to go ahead and replace it with the new rendering as the old 
one is broken anyway.

>> +#define SATTURATED_ADD(var, add)    \
> spelling:
> http://dictionary.die.net/saturated

Thanks, you are the first to notice, even though quite a few people already 
looked at it before I committed it.

In cases like this (as this has not been merged yet): Is amending or a new 
commit preferred?


Other related posts: