[haiku-commits] Re: BRANCH looncraz-github.setviewuicolor [24bb725ec18f] src/kits/interface

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Wed, 30 Sep 2015 18:34:36 -0700

On Wed, Sep 30, 2015 at 3:28 AM, looncraz <looncraz@xxxxxxxxxxx> wrote:

On 9/30/2015 05:14, Axel Dörfler wrote:

Am 29.09.2015 um 22:17 schrieb looncraz-github.setviewuicolor:

BRect rect(Bounds());
- rgb_color base = LowColor();
+ rgb_color base = ui_color(B_MENU_BACKGROUND_COLOR);


That doesn't look right. LowColor() should be corrected instead, maybe via
your SetUILowColor() call?

Why don’t you just pass ui_color(B_MENU_BACKGROUND_COLOR) into the
base parameter wherever it is that you are calling
DrawMenuBarBackground? I think I’m missing a bit of context here.

Other related posts: