[haiku-commits] Re: BRANCH HaikuPM-github.package-management [b4c8d2f] src/apps/haiku-depot
- From: Stephan Aßmus <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 19 Sep 2013 14:47:48 +0200
Hi Rene,
Am 19.09.2013 um 14:00 schrieb HaikuPM-github.package-management
<community@xxxxxxxxxxxx>:
> added 1 changeset to branch 'refs/remotes/HaikuPM-github/package-management'
> old head: 50792d1199fdc9a211beb49ab282a7ce0a5c4c03
> new head: b4c8d2ff49d89fa8d804bb8e58c6cf96fa01ecd0
> overview: https://github.com/haiku/HaikuPM/compare/50792d1...b4c8d2f
>
> ----------------------------------------------------------------------------
>
> b4c8d2f: HaikuDepot: Show installation state in list view.
>
> - Add package installation state to PackageInfo and update accordingly
> in Model.
[...]
> @@ -498,6 +501,7 @@ PackageInfo::operator=(const PackageInfo& other)
> fCategories = other.fCategories;
> fUserRatings = other.fUserRatings;
> fScreenshots = other.fScreenshots;
> + fState = other.fState;
> return *this;
> }
You missed one more spot to add this, operator==(const PackageInfo& other).
> +inline BString PackageStateToString(PackageState state)
> +{
Coding style, should be:
inline BString
package_state_to_string(PackageState state)
{
Really nice watching it being integrated! Awesome work!
Best regards,
-Stephan
Other related posts:
