[haiku-bugs] Re: [Haiku] #9687: [bin:kill] crashes if pid doesn't exit
- From: "anevilyak" <trac@xxxxxxxxxxxx>
- Date: Sat, 18 May 2013 12:56:59 -0000
#9687: [bin:kill] crashes if pid doesn't exit
-----------------------------------------------+---------------------------
Reporter: diver | Owner: anevilyak
Type: bug | Status: reopened
Priority: normal | Milestone: R1
Component: Applications/Command Line Tools | Version:
Resolution: | R1/Development
Blocked By: | Keywords:
Has a Patch: 0 | Blocking:
| Platform: All
-----------------------------------------------+---------------------------
Comment (by anevilyak):
Replying to [comment:11 bonefish]:
> I would revert the `is_number()` and `send_signals()` part of the
original patch (cc2c83fa5ce13347f19da08a40f43c256e96d9a6).
`send_signals()` already did a (correct!) check for a number. The only
thing to be changed there is calling `kill_by_name()` instead of failing.
Also, "OS.h" is not a local header.
Ah, I'd completely forgotten all of that was from a patch, thanks for the
hint.
> That being said, I'm not really happy about disabling the bash built-in
kill, as that removes the feature of killing jobs. So, if you ask me, I'd
revert the commit (and its fixes) until there's also a patch for the shell
built-in.
Could certainly do that, will have a look and see what patching the latter
would take.
--
Ticket URL: <http://dev.haiku-os.org/ticket/9687#comment:12>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
