[haiku-bugs] Re: [Haiku] #9528: stop_watching() KDLs on page fault, monitoring a CDDA

  • From: "ttcoder" <trac@xxxxxxxxxxxx>
  • Date: Tue, 20 May 2014 10:39:09 -0000

#9528: stop_watching() KDLs on page fault, monitoring a CDDA
-----------------------------+----------------------------
   Reporter:  ttcoder        |      Owner:  axeld
       Type:  bug            |     Status:  new
   Priority:  normal         |  Milestone:  R1
  Component:  System/Kernel  |    Version:  R1/Development
 Resolution:                 |   Keywords:
 Blocked By:                 |   Blocking:
Has a Patch:  0              |   Platform:  All
-----------------------------+----------------------------

Comment (by ttcoder):

 Good catch Jerome, one version of _RestoreAttributes() invokes close()
 whereas the other.. does not. Yet the calling code in Mount() did not
 compensate for that change. I guess it probably cannot result in a KDL
 page fault though.. But I'll include the missing `close(fd)` call in
 whatever patch I submit later (if I'm lucky to get to that stage :-) as
 leaking file descriptors is probably serious (dunno if there's resource
 tracking going on when the cdda addon is unloaded)..

--
Ticket URL: <https://dev.haiku-os.org/ticket/9528#comment:11>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: