[haiku-bugs] Re: [Haiku] #9293: Some Terminal enhancements
- From: "siarzhuk" <trac@xxxxxxxxxxxx>
- Date: Fri, 15 Mar 2013 15:51:39 -0000
#9293: Some Terminal enhancements
-------------------------------------+----------------------------
Reporter: Ziusudra | Owner: siarzhuk
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Applications/Terminal | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-------------------------------------+----------------------------
Comment (by siarzhuk):
Replying to [ticket:9293 Ziusudra]:
> Patch 0001 adds a haiku termcap entry that accurately describes
Terminal's current capabilities.
[[BR]]
I have rejected it. Terminal must be improved (see hrev45364 for example)
to mimic xterm-256color more accurately instead of introducing another bit
of Chaos in This World. ;-)
[[BR]]
> Patch 0002 updates the master termcap.src. It also disables warnings in
our ncurses.a;
[[BR]]
hrev45364 do something like this. Thank you for for some hints I have used
improving my version of termcap.src.
[[BR]]
> Patch 0003 is just a style cleanup of TermParse.cpp.
[[BR]]
obsoleted by hrev45364. Cleanup was performed on top of those changes
anyway.
[[BR]]
> Patch 0004 adds comments describing Terminal's terminfo/termcap
capabilities.
[[BR]]
I hope we switch to terminfo soon, so there no need to overload code with
such info, IMO.
[[BR]]
> Patch 0005 implements the other ACS characters that DejaVu has glyphs
for.
[[BR]]
Partially applied in hrev45367. Thank you for the contribution!
[[BR]]
> Patch 0006 makes SGR codes 39 & 49 actually reset the color as
{{{IS_FORESET}}} & {{{IS_BACKSET}}} are never used. Are they left over
from something that got removed, or are they something that didn't get
finished?
[[BR]]
Obsoleted by hrev45364.
[[BR]]
> Patch 0008 just removes a few lines of duplicated code in
{{{TermView::AttachedToWindow}}}.
[[BR]]
Applied in hrev45367. Thank you for the contribution!
[[BR]]
> Patch 0007 fixes a bug I noticed while testing where SIGWINCH was not
getting updated when the terminal size was changed by the
{{{Settings->Window size}}} menu.
> Patch 0009 removes the SIGWINCH message, runner, handler and flag as
they weren't used/needed.
[[BR]]
I'm investigating the SIGWINCH handling now. IMO replacing BMessageRunner-
driven handler with direct call of corresponding handler is not equal and
not safe. It
changes the processing context and may have unpleasant side-effects and
regressions.
[[BR]]
Thank you for your work anyway!
--
Ticket URL: <http://dev.haiku-os.org/ticket/9293#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
