[haiku-bugs] Re: [Haiku] #9268: BStringList::Sort with own comparing method.

  • From: "bonefish" <trac@xxxxxxxxxxxx>
  • Date: Thu, 06 Dec 2012 18:41:43 -0000

#9268: BStringList::Sort with own comparing method.
--------------------------------+------------------------------------
   Reporter:  dknoto            |      Owner:  axeld
       Type:  enhancement       |     Status:  new
   Priority:  normal            |  Milestone:  R1
  Component:  Kits/Support Kit  |    Version:  R1/Development
 Resolution:                    |   Keywords:  BString, Sort, compare
 Blocked By:                    |   Blocking:
Has a Patch:  1                 |   Platform:  All
--------------------------------+------------------------------------

Comment (by bonefish):

 As commented in #9267 please use `git format-patch` to create your
 patches.

 Regarding this patch, intended is a `Sort()` method with a compare
 function that operates on `const BString&` and maybe a second one with
 `const char*` parameters. That essentially means avoiding
 BList::SortItems() and rather using `std::sort()` directly on
 `BList::Items()` with a respective comparison class. That would also be a
 preferable alternative for the existing `Sort()` method.

 Please mind our coding style guidelines. There should be two blank lines
 between function definitions.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/9268#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: