[haiku-bugs] Re: [Haiku] #8256: [Terminal] remember color schema settings [easy]

  • From: "luckypower" <trac@xxxxxxxxxxxx>
  • Date: Fri, 13 Apr 2012 21:03:41 -0000

#8256: [Terminal] remember color schema settings [easy]
   Reporter:  Disreali               |      Owner:  siarzhuk
       Type:  bug                    |     Status:  assigned
   Priority:  normal                 |  Milestone:  R1
  Component:  Applications/Terminal  |    Version:  R1/Development
 Resolution:                         |   Keywords:  GSOC2012
 Blocked By:                         |   Blocking:
Has a Patch:  1                      |   Platform:  All

Comment (by luckypower):

 Replying to [comment:13 siarzhuk]:
 > Replying to [comment:12 bonefish]:
 > > Replying to [comment:11 siarzhuk]:
 > > > I suspect that both cursor colors of the Color object are not used
 at the moment. So if the Color objects really contain not-initialized
 trash here
 > >
 > > I would suspect something like that as well, but if that's the case,
 the better solution would be either to remove these attributes completely
 (not just in the `==` operator) or -- particularly if there's any
 intention to use them in the future -- initialize them properly (and keep
 the comparison in the `==` operator).
 > You are right. Correct initialization of the object fileds is looking
 like more correct way to solve theproblem at the moment. ;-)

 Thanks for correcting me. cursor_fore_color and cursor_back_color was not
 set when we change the schema. So i thought it must not be checked when we
 compare schema. But I will come up with better solution, as both of you

Ticket URL: <http://dev.haiku-os.org/ticket/8256#comment:14>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: