[haiku-bugs] Re: [Haiku] #7629: Patch to make BJoystick non blocking on read
- From: "mmlr" <trac@xxxxxxxxxxxx>
- Date: Fri, 03 Jun 2011 13:39:21 -0000
#7629: Patch to make BJoystick non blocking on read
-------------------------------+----------------------------
Reporter: caz_haiku | Owner: mmlr
Type: enhancement | Status: closed
Priority: normal | Milestone: R1
Component: Kits/Device Kit | Version: R1/Development
Resolution: fixed | Keywords: Joystick
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-------------------------------+----------------------------
Comment (by mmlr):
Replying to [comment:8 caz_haiku]:
> Just tested things and as expected it works great :-0.
Cool.
> The num_sticks thing was to do with old standard gameport Sidewinder
gamepads which you could daisy chain up to 4 controllers connected to each
other, so indeed they did have the same attributes.
Yes I know, it's documented in the newsletter article IIRC. Still it's a
questionable decision API design wise since just providing seperate
devices for each stick would've been less complex from an app developer
side of things as you wouldn't have to take into account devices **and**
sticks, even though you're going to handle their input the same way in
both cases anyway.
The "best guess" was directed at the implementation of BJoystick::Update()
however, as I don't know (and can't test) how addressing the different
sticks was implemented in the original BJoystick. Therefore I've just
implemented it by using the stick number as position to the read call
which may be the right thing, or maybe not...
> Also the old legacy axes values horizontal and vertical should be the
same as the enhanced ones IIRC.
Indeed, I was mislead by the legacy joystick structure data type and
thought there was a need for conversion, which there isn't. I've fixed
that in r41875.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7629#comment:9>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
