[haiku-bugs] Re: [Haiku] #6497: MediaConverter does not handle errors gracefully when sniffing files (easy)
- From: "stippi" <trac@xxxxxxxxxxxx>
- Date: Tue, 16 Nov 2010 09:51:42 -0000
#6497: MediaConverter does not handle errors gracefully when sniffing files
(easy)
------------------------------------------+------------------------------
Reporter: yourpalal | Owner: stippi
Type: bug | Status: closed
Priority: normal | Milestone: R1
Component: Applications/MediaConverter | Version: R1/Development
Resolution: fixed | Keywords:
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
------------------------------------------+------------------------------
Comment (by stippi):
The new patch looks mostly fine. The only problem is the _IsMediaFile().
In principle it's a good idea, but there are media file MIME types other
than video/* and audio/*, for example application/ogg, but there are
others. MediaPlayer does something similar, but it also looks for its own
supported types for a fall back. At least the user can then force
MediaPlayer to consider a file as supported regardless. In the case of
MediaConverter, I would keep the old mechanism of trying to parse the file
regardless of type. I don't know where you saw the delay... if this
happens when the files are added to the list, it could be a solution to
delay the sniffing to until the file is converted. What do you think?
--
Ticket URL: <http://dev.haiku-os.org/ticket/6497#comment:11>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
