[haiku-bugs] Re: [Haiku] #6227: Terminal TermParse::EscParse() 2 issues.

  • From: "siarzhuk" <trac@xxxxxxxxxxxx>
  • Date: Sun, 13 Nov 2011 21:01:44 -0000

#6227: Terminal TermParse::EscParse() 2 issues.
-------------------------------------+------------------------
   Reporter:  h.z                    |      Owner:  jackburton
       Type:  bug                    |     Status:  new
   Priority:  normal                 |  Milestone:  R1
  Component:  Applications/Terminal  |    Version:  R1/alpha2
 Resolution:                         |   Keywords:
 Blocked By:                         |   Blocking:
Has a Patch:  0                      |   Platform:  All
-------------------------------------+------------------------

Comment (by siarzhuk):

 First issue (invalid destLen was sent to convert_to_utf8) fixed in
 hrev43252.

 Some comments about the second one:

 1) UTF8.h says that:

 {{{
 41 B_GBK_CONVERSION, // Chinese GB18030
 }}}

 But GB 18030 is an extension of GBK. They are different encodings! Are
 there anybody flyent in iconv's architecture to check which encoding is
 used behind the scenes of our convert_xx_utf8?

 2) Those ranges in the patch looks like come from the following info
 (root/src/libs/iconv/gb18030.h):

 {{{
 * GB18030, as specified in the GB18030 standard, is an extension of GBK.
 * In what follows, page numbers refer to the GB18030 standard (second
 * printing).
 * It consists of the following parts:
 *
 * One-byte range:
 *   ASCII        p. 2         0x{00..7F}
 *
 * Two-byte range:
 *   GBK part 1   p. 10..12    0x{A1..A9}{A1..FE}
 *   GBK part 2   p. 13..36    0x{B0..F7}{A1..FE}
 *   GBK part 3   p. 37..52    0x{81..A0}{40..7E,80..FE}
 *   GBK part 4   p. 53..81    0x{AA..FE}{40..7E,80..A0}
 *   GBK part 5   p. 82        0x{A8..A9}{40..7E,80..A0}
 *   UDA part 1   p. 83..84    0x{AA..AF}{A1..FE}
 U+E000..U+E233
 *   UDA part 2   p. 85..87    0x{F8..FE}{A1..FE}
 U+E234..U+E4C5
 *   UDA part 3   p. 88..90    0x{A1..A7}{40..7E,80..A0}
 U+E4C6..U+E765
 }}}

 So things are looking more complicate that a simple fallback to
 CASE_PRINT_GR anyway. ;-)

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/6227#comment:11>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: