[haiku-bugs] Re: [Haiku] #5969: Terminal size is not correct when 2nd tab is added in zoom/fullscreen

  • From: "stippi" <trac@xxxxxxxxxxxx>
  • Date: Wed, 12 May 2010 22:11:55 -0000

#5969: Terminal size is not correct when 2nd tab is added in zoom/fullscreen
-----------------------------------+----------------------------------------
 Reporter:  romain                 |       Owner:  jackburton
     Type:  bug                    |      Status:  new       
 Priority:  normal                 |   Milestone:  R1        
Component:  Applications/Terminal  |     Version:  R1/alpha2 
 Keywords:                         |   Blockedby:            
 Platform:  All                    |    Blocking:            
-----------------------------------+----------------------------------------

Comment(by stippi):

 Thanks for the patch!

  * In the first hunk, a single ResizeToPreferred() should be equivalent to
 getting the preferred size and resizing to that.

  * The second part looks reasonable to me. However, I would put the
 declaration of rows and columns directly above the call where they get
 used. Also, to find out where the view is resized to such small values,
 you could add a debugger() invokation when you detect the values are
 unreasonable, and then you get a stack trace and know from where this
 happens.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/5969#comment:1>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: