[haiku-bugs] Re: [Haiku] #5940: Header file for the USB video driver
- From: "mmlr" <trac@xxxxxxxxxxxx>
- Date: Sat, 08 May 2010 14:23:59 -0000
#5940: Header file for the USB video driver
-------------------------------+--------------------------------------------
Reporter: Karvjorm | Owner: mmlr
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Drivers/USB | Version: R1/Development
Keywords: USB video drivers | Blockedby:
Platform: All | Blocking:
-------------------------------+--------------------------------------------
Comment(by mmlr):
Interesting. Got two remarks though:
For struct usb_video_processing_unit_descriptor I'd rather see the Dx
named with what they are, as it looks like they all have a specific and
fixed meaning. I'd rather use a native type like uint32 instead of the
unsigned for these bitfields as well. Using the BITFIELD macros might make
sense considering endianness awareness of those. Also I'm not sure the
anonymous structs work with gcc2.
There are some stray comments in the "Video Interface Subclass Codes"
enum.
Otherwise it looks good, thanks for looking into it.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5940#comment:1>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
