[haiku-bugs] Re: [Haiku] #5850: Terminal localization patch
- From: "stippi" <trac@xxxxxxxxxxxx>
- Date: Wed, 28 Apr 2010 21:37:45 -0000
#5850: Terminal localization patch
-----------------------------------------------+----------------------------
Reporter: Karvjorm | Owner: stippi
Type: enhancement | Status: in-progress
Priority: normal | Milestone: R1
Component: Applications/Terminal | Version: R1/alpha1
Keywords: Terminal localization ISO 8859-15 | Blockedby:
Platform: All | Blocking:
-----------------------------------------------+----------------------------
Changes (by stippi):
* owner: jackburton => stippi
* status: new => in-progress
Comment:
Patch looks mostly good. A few things you could fix:
src/apps/terminal/Shell.cpp:515/519, the part "alert --stop" should not be
part of the translated string, otherwise it's too easy to break the
functionality in translations. That is unless we want to translate command
line options for apps like alert. ;-)
src/apps/terminal/TermView.cpp:1857, can you change the string "Secondary
Mouse Button Drop Menu" to "Secondary mouse button drop menu"? We changed
most strings in Haiku to sentence case a while back. This string won't
usually be seen by users, since it's the internal name of the menu, but
it's possible to see it as window title for example in ProcessController.
Lastly, I am missing an important detail. Somewhere you should have a
BCatalog fAppCatalog variable declared, most probably in the Terminal
BApplication class and load it at init time. Without this, Terminal should
crash.
Thanks a lot for the work, I will be happy to submit it with the above
changes! :-)
--
Ticket URL: <http://dev.haiku-os.org/ticket/5850#comment:1>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
