[haiku-bugs] Re: [Haiku] #5690: Filetypes: use Layout API
- From: "yourpalal" <trac@xxxxxxxxxxxx>
- Date: Wed, 07 Apr 2010 08:18:35 -0000
#5690: Filetypes: use Layout API
-----------------------------------+----------------------------------------
Reporter: yourpalal | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Preferences/FileTypes | Version: R1/alpha1
Keywords: GSoc | Blockedby:
Platform: All | Blocking:
-----------------------------------+----------------------------------------
Comment(by yourpalal):
thanks Stippi! I don't think I ever considered the difference in messages
for a BTextControl, good catch there. I'm not sure why I removed those
calls to SetEnabled() but I will fix that as well. I did try to follow the
coding guidelines, but obviously I didn't do very well! I think what you
might be mentioning for the sudden indentation is the code that uses
LayoutBuilders, which I tried to follow the style used in this article
http://www.haiku-os.org/documents/dev/laying_it_all_out_part_1 (you can
see this by ctrl-f for Builder, if you're interested). Anyway, I will make
those changes you've mentioned, do a thorough examination of the patch to
find any other mistakes and put up a new patch, hopefully sometime this
week, or on the weekend. Thanks again for reviewing the patch, your
feedback is very helpful!
--
Ticket URL: <http://dev.haiku-os.org/ticket/5690#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
