[haiku-bugs] Re: [Haiku] #5454: [patch] added rule UntarArchive
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Thu, 25 Feb 2010 15:03:22 -0000
#5454: [patch] added rule UntarArchive
---------------------------+------------------------------------------------
Reporter: mmadia | Owner: bonefish
Type: enhancement | Status: closed
Priority: normal | Milestone: R1
Component: Build System | Version: R1/Development
Resolution: fixed | Keywords:
Blockedby: | Platform: All
Blocking: 5457 |
---------------------------+------------------------------------------------
Changes (by bonefish):
* status: new => closed
* resolution: => fixed
Comment:
Replying to [comment:6 mmadia]:
I've applied the patch in r35616.
> I overlooked 80char limit with this and the other patches.
Fixed in the commit.
> Once the implementation is how you like it, i'll gladly resubmit final
patches. Also, I haven't tested the behavior with .tar.gz yet. Though, my
#5457 was updated and jam -q @nightly-raw built successfully.
IIRC the ":S" only selects the last extension, i.e. the ".gz". If that is
indeed so, something like the following might work to check for ".tar.gz":
{{{
...
case .gz :
{
local baseName = $(archiveFile:B) ;
if $(baseName:S) = .tar {
...
} else {
...
}
}
}}}
> Afterwards, I could look into updating the UnzipArchiveTo* and
AddUnzipFile* rules if desired.
Only, if there's a reason to do that. I wouldn't want to add complexity,
if not needed.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5454#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
