[haiku-bugs] Re: [Haiku] #5419: PPC: PATCH: Playing catch up to new x86 VMTranslationMap
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Wed, 17 Feb 2010 11:02:16 -0000
#5419: PPC: PATCH: Playing catch up to new x86 VMTranslationMap
----------------------------+-----------------------------------------------
Reporter: kallisti5 | Owner: axeld
Type: bug | Status: closed
Priority: normal | Milestone: R1/alpha2
Component: System/Kernel | Version: R1/Development
Resolution: invalid | Keywords:
Blockedby: | Platform: PowerPC
Blocking: |
----------------------------+-----------------------------------------------
Changes (by bonefish):
* status: new => closed
* resolution: => invalid
Comment:
Besides that the patch introduces style violations (spacing between
functions) it also removes functionality. UnmapPages() and UnmapArea()
have been omitted on purpose, since the base class provides (slow)
fallback implementations. Adding ProtectPage() and ProtectArea() is
utterly pointless, since they aren't virtual and the base class implements
them inline in the header.
BTW, the reason for the X86VMTranslationMap class to have its own header
is that the class is used outside arch_vm_translation_map.cpp, which, at
least ATM, does not apply to the PPC implementation. So I would leave it
were it is.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5419#comment:1>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
