[haiku-bugs] Re: [Haiku] #5169: Sentence casing the GUI (patch)

  • From: "humdinger" <trac@xxxxxxxxxxxx>
  • Date: Fri, 25 Dec 2009 17:35:35 -0000

#5169: Sentence casing the GUI (patch)
----------------------------+-----------------------------------------------
 Reporter:  humdinger       |       Owner:  stippi        
     Type:  enhancement     |      Status:  new           
 Priority:  normal          |   Milestone:  R1            
Component:  User Interface  |     Version:  R1/Development
 Keywords:                  |   Blockedby:                
 Platform:  All             |    Blocking:                
----------------------------+-----------------------------------------------

Comment(by humdinger):

 I think I've messed up some things in DriveSetup. I mistakenly renamed
 e.g. "Intel Partition Map" to "Intel partition map". I just wanted for
 initialize a partition and couldn't, while another clean Haiku
 installation did work.

 These are the the erroneous diffs, I think:
 {{{
 @@ -801,9 +801,9 @@

         // allow BFS only, since our parameter string
         // construction only handles BFS at the moment
 -       if (diskSystemName != "Be File System"
 -               && diskSystemName != "Intel Partition Map"
 -               && diskSystemName != "Intel Extended Partition") {
 +       if (diskSystemName != "Be file system"
 +               && diskSystemName != "Intel partition map"
 +               && diskSystemName != "Intel extended partition") {
                 _DisplayPartitionError("Don't know how to construct
 parameters "
                         "for this file system.");
                 return;
 @@ -819,14 +819,14 @@

         BString name;
         BString parameters;
 -       if (diskSystemName == "Be File System") {
 +       if (diskSystemName == "Be file system") {
                 InitParamsPanel* panel = new InitParamsPanel(this,
 diskSystemName,
                         partition);
                 if (panel->Go(name, parameters) == GO_CANCELED)
                         return;
 -       } else if (diskSystemName == "Intel Partition Map") {
 +       } else if (diskSystemName == "Intel partition map") {
                 // TODO: parameters?
 -       } else if (diskSystemName == "Intel Extended Partition") {
 +       } else if (diskSystemName == "Intel extended partition") {
                 // TODO: parameters?
         }
 }}}
 Sorry about that.

 I attached an updated version: case-apps-UPDATED.diff. Please use that
 instead.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/5169#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: