#4938: ACPI problems (implement sleep modes and lid driver)
---------------------------+-------------------------
Reporter: skfir | Owner: nobody
Type: enhancement | Status: closed
Priority: normal | Milestone: Unscheduled
Component: Drivers/ACPI | Version: R1/alpha1
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Platform: All |
---------------------------+-------------------------
Comment (by pulkomandy):
This ticket is not really the place to discuss this, but anyways:
tqh is our local ACPI expert, if he says the ticket can be closed, he is
probably right and we can assume he knows what he is doing. If you don't
understand why he closed the ticket, instead of reopening, you could have
simply asked him to clarify why he closed it, to clear the
misunderstanding or make sure it wasn't by mistake. It would have saved
time and frustration for all 3 of us.
Regarding the -2 tickets, I have a few myself, for changes that I think
are of not great consequences and I don't always want to put the energy on
getting them in a state where everyone is perfectly happy about them. And,
since a -2 is blocking other people until you (the person who put a -2 in
the first place) manually remove them, it is perceived as strongly
blocking (it is, effectively, a veto to a change). That can be useful in
some cases, but for the general discussion between developers, I think we
could use -1, or even no vote at all, and do the code review with just
comments and trust each other that people won't merge something without
solving all comments that they feel are important, and it does not need
your personal approval to check that they have done so.
We already had this discussion and I had proposed to change the way the -2
works, but that wasn't accepted either.
--
Ticket URL: <https://dev.haiku-os.org/ticket/4938#comment:10>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.