[haiku-bugs] Re: [Haiku] #4494: [Terminal] some default color settings are hard to read

  • From: "Prasad" <trac@xxxxxxxxxxxx>
  • Date: Mon, 08 Oct 2012 17:44:36 -0000

#4494: [Terminal] some default color settings are hard to read
-------------------------------------+------------------------
   Reporter:  scottmc                |      Owner:  jackburton
       Type:  bug                    |     Status:  new
   Priority:  normal                 |  Milestone:  R1
  Component:  Applications/Terminal  |    Version:  R1/alpha1
 Resolution:                         |   Keywords:  gci2011
 Blocked By:                         |   Blocking:
Has a Patch:  1                      |   Platform:  All
-------------------------------------+------------------------

Comment (by Prasad):

 Replying to [comment:15 korli]:
 > Replying to [comment:12 Prasad]:
 > > > it seems your patch doesn't include changes for src/dircolors.hin.
 Could you please add this and update the patch? Thanks.
 > >
 > > I am not sure I understand you correctly, but seems like the latest
 diff in dircolrs.hin is already reflected in the latest source code
 >
 > Your patch modifies dircolors.h which is a generated file based on
 dircolors.hin. Thus your modification of dircolors.h might be lost anytime
 dircolors.h is regenerated (or coreutils is updated or outsourced). It
 should take place at line 83 if I'm not mistaken.

 Thanks I was not aware of the fact dircolors.h is auto-generated. I have
 attached another patch
 [https://dev.haiku-os.org/attachment/ticket/4494/0001-Change-color-scheme-
 for-other-writable-directory.4.patch
 ] please check if it is suitable.

 However, I am not able to figure out the reason for committing the
 dircolors.h in the repository. Since it is auto-generated, it could have
 been generated while building the source itself.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/4494#comment:16>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: