#15625: After using "Open Link in new window" the session is lost
---------------------------+---------------------------------
Reporter: jmairboeck | Owner: pulkomandy
Type: bug | Status: new
Priority: high | Milestone: Unscheduled
Component: Kits/Web Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking: 13699, 15235, 16460
Platform: All |
---------------------------+---------------------------------
Comment (by pulkomandy):
I suspect multiple instances of NetworkStorageSession are somehow created
(when creating new tabs). It's unclear how these methods work together and
what the expected flow is:
https://github.com/haiku/haikuwebkit/blob/haiku/Source/WebKitLegacy/haiku/WebCoreSupport/FrameNetworkingContextHaiku.cpp#L77
https://github.com/haiku/haikuwebkit/blob/haiku/Source/WebKitLegacy/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp#L1000
https://github.com/haiku/haikuwebkit/blob/haiku/Source/WebCore/platform/network/haiku/NetworkStorageSessionHaiku.cpp#L58
There are also various functions to set cookies that are not implemented:
https://github.com/haiku/haikuwebkit/blob/haiku/Source/WebCore/platform/network/haiku/NetworkStorageSessionHaiku.cpp#L124
We also didn't fully implement "private browsing" which would normally use
a separate NetworkStorageSession instance (with a separate cookie jar,
history, etc, that would not be saved to disk in any case). Normally this
would use PAL::SessionID to identify a separate browsing session. I don't
know what we're expected to do with that (in NetworkStorageSession
constructor) and how much of it is already managed by WebKit. We should
probably check if we get a single session or multiple ones.
--
Ticket URL: <https://dev.haiku-os.org/ticket/15625#comment:10>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
