[haiku-bugs] Re: [Haiku] #13611: [PATCH] Fix window behavior when default button is present

  • From: "axeld" <trac@xxxxxxxxxxxx>
  • Date: Wed, 19 Jul 2017 07:44:34 -0000

#13611: [PATCH] Fix window behavior when default button is present
----------------------------------+----------------------------
   Reporter:  KapiX               |      Owner:  nobody
       Type:  enhancement         |     Status:  new
   Priority:  normal              |  Milestone:  Unscheduled
  Component:  Kits/Interface Kit  |    Version:  R1/Development
 Resolution:                      |   Keywords:
 Blocked By:                      |   Blocking:
Has a Patch:  1                   |   Platform:  All
----------------------------------+----------------------------

Comment (by axeld):

 Looks good, thanks. There are two minor style issues, though, that I would
 appreciate if you could fix them:
 - constants should get the 'k' prefix. The name should then probably be
 improved to kAnyModifier.
 - We prefer == 0 instead of !:
 {{{(modifiers() & modifierKeys) == 0}}}

--
Ticket URL: <https://dev.haiku-os.org/ticket/13611#comment:2>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: